Throw big table diffs for missing tables or size diffs#118
Conversation
Myoldmopar
left a comment
Myoldmopar
left a comment
There was a problem hiding this comment.
Walkthrough complete.
| @@ -1,2 +1,2 @@ | |||
| NAME = 'energyplus_regressions' | |||
| VERSION = '2.1.4' | |||
| VERSION = '2.1.5' | |||
| table_not_in_2 = 1 | ||
| count_of_not_in_2 += table_not_in_2 | ||
| table_big_diff = 1 | ||
| count_of_big_diff += table_big_diff |
There was a problem hiding this comment.
A table that is missing in the mod branch is now going to also report a table big diff.
| table_size_error = 1 | ||
| count_of_size_error += table_size_error | ||
| table_big_diff = 1 | ||
| count_of_big_diff += table_big_diff |
There was a problem hiding this comment.
A table that has a mismatched size (row count change, column count change, empty, etc.), will now also report a table big diff.
| </tr> | ||
| <tr> | ||
| <td align="right">None</td> | ||
| <td align="right"></td> |
There was a problem hiding this comment.
New test mod file, I've cleared out the building area table here to represent a size change.
| self.assertEqual(0, response[5]) # string diffs | ||
| self.assertEqual(1, response[6]) # size errors | ||
| self.assertEqual(0, response[7]) # in file 2 but not in file 1 | ||
| self.assertEqual(0, response[8]) # in file 1 but not in file 2 |
There was a problem hiding this comment.
And the new unit test, noting a size error and also a big diff.
| self.assertEqual('', response[0]) # diff status | ||
| self.assertEqual(3, response[1]) # count_of_tables | ||
| self.assertEqual(0, response[2]) # big diffs | ||
| self.assertEqual(1, response[2]) # big diffs |
There was a problem hiding this comment.
This test is also sufficient, really, and needed to bump it up to include the big diff.
|
Alright, merging this in and making a new release. |
1 participant
We do capture table diffs resulting from a table that goes missing, or a table that has a size error. But as of now, these don't also throw a BIG DIFF, so they are easier to look past. I simply added that it should throw a big diff in addition to the missing/size diffs that are also captured.
New test files and unit test added, other tests updated to now have the big diff in place.